-
Notifications
You must be signed in to change notification settings - Fork 10k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clear caches from more places on a hot reload event #32509
Conversation
4f6029f
to
067f5b5
Compare
FYI @tommcdon \ @mikem8361 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Is there a way we could centralize the "clear" behavior into a cache type?
I like this. It's less likely we would add a new cache in the future and forget to clear it up if we do this. |
src/JSInterop/Microsoft.JSInterop/src/Infrastructure/DotNetDispatcher.cs
Show resolved
Hide resolved
(Deleted comment posted on the wrong PR) |
While centralizing the caches sounds nice on paper, it's a bit difficult. The caches are on a mix of instance and static types which makes the cache lifetime hard to pin down. Additionally, they're also split across several assemblies that do not have IVT access to each other. We definitely don't want to introduce public APIs for caches. I'm going to punt on doing that for now. MVC might be a bit more open to this option since all of it's caches are non-static. |
No description provided.